-
Notifications
You must be signed in to change notification settings - Fork 31
test(e2e): Address some Admin UI test flakiness #2934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May also want to include an update to the use of a .CodeMirror
locator after #2679 is merged.
EDIT: Seems like it may take some more time for the linked PR to be completed. I'd like to get these fixes merged in first.
6b09d75
to
36a4daf
Compare
36a4daf
to
b680904
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I was getting failures on pagination/sorting but it looks like it also happened on main for me so it might be just my setup
Description
This PR addresses some flakiness in Admin UI e2e tests
Some of the recently added tests were running into situations where they would try to act on something before the page finished loading. For example, one test would try to access the
sign out
menu before the main view (i.e. projects page) finished loading. This caused the test to hang. Instead, the test was updated to wait for the projects page to appear.There was a recent update to the
boundaryCli.createRole
method that added the ability to provide aname
to the method. However, this caused other usages of the method to break. Supposedly, you need to provide an empty object if you don't want to provide aname
.On rare occasions, a particular alias test (in enterprise) would fail would trying to run
boundary connect ssh {alias}
, claiming that the connection was unsuccessful. I'm not entirely sure what's going on there, but I rearranged the test a little bit to give some more time before attempting to run the connect command.Made a locator more explicit to avoid conflicts when a resource id has the text
ok
in itA URL navigation needed to be changed because navigating to the projects page defaults you to the targets in the project as opposed to the project settings. Modified the url to navigate to
/edit
How to Test
Checklist
PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.