Skip to content

Conversation

moduli
Copy link
Collaborator

@moduli moduli commented Jul 17, 2025

Description

This PR addresses some flakiness in Admin UI e2e tests

  1. Some of the recently added tests were running into situations where they would try to act on something before the page finished loading. For example, one test would try to access the sign out menu before the main view (i.e. projects page) finished loading. This caused the test to hang. Instead, the test was updated to wait for the projects page to appear.

  2. There was a recent update to the boundaryCli.createRole method that added the ability to provide a name to the method. However, this caused other usages of the method to break. Supposedly, you need to provide an empty object if you don't want to provide a name.

  3. On rare occasions, a particular alias test (in enterprise) would fail would trying to run boundary connect ssh {alias}, claiming that the connection was unsuccessful. I'm not entirely sure what's going on there, but I rearranged the test a little bit to give some more time before attempting to run the connect command.

  4. Made a locator more explicit to avoid conflicts when a resource id has the text ok in it

  5. A URL navigation needed to be changed because navigating to the projects page defaults you to the targets in the project as opposed to the project settings. Modified the url to navigate to /edit

How to Test

enos scenario launch ...
pnpm admin:ce:docker
pnpm admin:ce:aws
pnpm admin:ent:docker
pnpm admin:ent:aws

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

Copy link

vercel bot commented Jul 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
boundary-ui Ready Ready Preview Comment Sep 3, 2025 3:19pm
boundary-ui-desktop Ready Ready Preview Comment Sep 3, 2025 3:19pm

Copy link
Collaborator Author

@moduli moduli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May also want to include an update to the use of a .CodeMirror locator after #2679 is merged.

EDIT: Seems like it may take some more time for the linked PR to be completed. I'd like to get these fixes merged in first.

@moduli moduli force-pushed the moduli-e2e-fixes branch from 6b09d75 to 36a4daf Compare August 5, 2025 22:24
Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I was getting failures on pagination/sorting but it looks like it also happened on main for me so it might be just my setup

@moduli moduli merged commit 1bafbe1 into main Sep 3, 2025
14 checks passed
@moduli moduli deleted the moduli-e2e-fixes branch September 3, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants