-
Notifications
You must be signed in to change notification settings - Fork 33
fix: 🐛 OIDC authentications not properly showing username #2930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🐛 OIDC authentications not properly showing username #2930
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1eeece9 to
6e20c6c
Compare
…roperly-showing-username
hashicc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the fact that this all lives on the a specific user model means that we don't need to copy over and modify to the data.authenticated hash, we can probably derive it more easily from a getter that does a peekRecord, and rely on the certain points in the application flow to refresh the model as needed
cameronperera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work Lis!
ZedLi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I assume the test changes you've already made are now optional (which is fine) because having a username can fail?
Yup that is correct, the only tests that would fail without the changes would be tests validating the dropdown has correct username. |
DhariniJeeva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix!
priya-patel04
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thanks for the fix
…roperly-showing-username
…wing-username' of https://github.com/hashicorp/boundary-ui into ICU-17231-bug-fix-oidc-authentications-not-properly-showing-username
72a0ece
…roperly-showing-username
got some approvals & PR feedback applied
✅ Closes: https://hashicorp.atlassian.net/browse/ICU-17231
Description
Use account_id (retrieved from authenticated data) to query authenticated account in order to display correct username for any authentication method. As a result, OIDC authentications should show proper username.
Screenshots (if appropriate)
OIDC + Password Auth in Admin UI:
Screen.Recording.2025-09-24.at.4.25.39.PM.mov
OIDC + Password Auth in Desktop UI:
Screen.Recording.2025-09-24.at.4.23.31.PM.mov
How to Test
Checklist
PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.