Skip to content

Conversation

@lisbet-alvarez
Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez commented Jul 15, 2025

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-17231

Description

Use account_id (retrieved from authenticated data) to query authenticated account in order to display correct username for any authentication method. As a result, OIDC authentications should show proper username.

Screenshots (if appropriate)

OIDC + Password Auth in Admin UI:

Screen.Recording.2025-09-24.at.4.25.39.PM.mov

OIDC + Password Auth in Desktop UI:

Screen.Recording.2025-09-24.at.4.23.31.PM.mov

How to Test

  1. Have OIDC auth method available
  2. Validate username is displayed correctly after login.
  3. Test in both admin and desktop UI

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@vercel
Copy link

vercel bot commented Jul 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
boundary-ui Ready Ready Preview Comment Oct 30, 2025 6:44pm
boundary-ui-desktop Ready Ready Preview Comment Oct 30, 2025 6:44pm

hashicc
hashicc previously requested changes Oct 2, 2025
Copy link
Collaborator

@hashicc hashicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the fact that this all lives on the a specific user model means that we don't need to copy over and modify to the data.authenticated hash, we can probably derive it more easily from a getter that does a peekRecord, and rely on the certain points in the application flow to refresh the model as needed

cameronperera
cameronperera previously approved these changes Oct 20, 2025
Copy link
Collaborator

@cameronperera cameronperera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Lis!

ZedLi
ZedLi previously approved these changes Oct 20, 2025
Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I assume the test changes you've already made are now optional (which is fine) because having a username can fail?

@lisbet-alvarez
Copy link
Collaborator Author

Looks good, I assume the test changes you've already made are now optional (which is fine) because having a username can fail?

Yup that is correct, the only tests that would fail without the changes would be tests validating the dropdown has correct username.

DhariniJeeva
DhariniJeeva previously approved these changes Oct 21, 2025
Copy link
Collaborator

@DhariniJeeva DhariniJeeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

priya-patel04
priya-patel04 previously approved these changes Oct 22, 2025
Copy link
Collaborator

@priya-patel04 priya-patel04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for the fix

@lisbet-alvarez lisbet-alvarez dismissed hashicc’s stale review October 30, 2025 18:43

got some approvals & PR feedback applied

@lisbet-alvarez lisbet-alvarez merged commit 72f7c8a into main Oct 30, 2025
19 of 20 checks passed
@lisbet-alvarez lisbet-alvarez deleted the ICU-17231-bug-fix-oidc-authentications-not-properly-showing-username branch October 30, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants