Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test selectors for credential-store/credentials create test #2756

Merged

Conversation

calcaide
Copy link
Collaborator

Description

Refactor test selectors for credential-store/credentials create test

🎟️ Jira ticket

How to Test

  • Run test successfully.

@calcaide calcaide self-assigned this Mar 28, 2025
@calcaide calcaide requested a review from a team as a code owner March 28, 2025 22:31
Copy link

vercel bot commented Mar 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2025 8:25pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2025 8:25pm

Copy link
Collaborator

@laurenolivia laurenolivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one question

Copy link
Collaborator

@DhariniJeeva DhariniJeeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks for the refactor

Copy link
Collaborator

@priya-patel04 priya-patel04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@calcaide calcaide merged commit bef9b3b into main Apr 8, 2025
13 checks passed
@calcaide calcaide deleted the refactor-ICU-15475-test-selectors-credentials-create-test branch April 8, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants