refactor: 💡 Force requests in playwright to use controller addr #2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ZedLi
commented
Mar 28, 2025
lisbet-alvarez
approved these changes
Mar 28, 2025
ZedLi
force-pushed
the
fix-request-usage-in-playwright
branch
from
cd07155 to
e314420
Compare
cameronperera
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a followup to PR #2700 and this thread, we should always be using the controller URL when making HTTP requests.
This PR overrides the
requestfixture with our own custom one that forces the baseURL to be the boundary controller URL, which fixes the issue in cases when testing against a local admin branch as the baseURL for requests would then be pointing incorrectly against the locally running server.How to Test
Try running the tests against a local branch for admin UI.