Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🤖 remove rose::nav::breadcrumbs #2750

Merged

Conversation

DhariniJeeva
Copy link
Collaborator

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-16790

Description

This PR removes rose::nav::breadcrumb since this component was migrated to HDS sometime ago

Screenshots (if appropriate)

How to Test

Checklist

  • [ ] I have added before and after screenshots for UI changes
  • [ ] I have added JSON response output for API changes
  • [ ] I have added steps to reproduce and test for bug fixes in the description
  • [ ] I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works

@DhariniJeeva DhariniJeeva requested a review from a team as a code owner March 27, 2025 16:21
Copy link

vercel bot commented Mar 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 6:15pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 6:15pm

Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

Copy link
Collaborator

@hashicc hashicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 awesome!

Copy link
Collaborator

@cameronperera cameronperera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Collaborator

@priya-patel04 priya-patel04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

Copy link
Collaborator

@calcaide calcaide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's goo!! 🧹 thanks for the clean up!

Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Cleanup!!!

@DhariniJeeva DhariniJeeva merged commit 69d127a into main Mar 28, 2025
21 checks passed
@DhariniJeeva DhariniJeeva deleted the ICU-16790-layout-components-retire-rose-nav-breadcrumbs branch March 28, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants