Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 🤖 add test selectors to roles grants tests #2749

Merged
merged 11 commits into from
Mar 31, 2025
Merged

chore: 🤖 add test selectors to roles grants tests #2749

merged 11 commits into from
Mar 31, 2025

Conversation

cameronperera
Copy link
Collaborator

Description

add test selectors to roles grants tests

🎟️ Grants

Screenshots (if appropriate)

How to Test

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@cameronperera cameronperera self-assigned this Mar 26, 2025
@cameronperera cameronperera requested a review from a team as a code owner March 26, 2025 18:17
@vercel Vercel
Copy link

vercel bot commented Mar 26, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 2:43pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 2:43pm

@cameronperera cameronperera force-pushed the ICU-16411-roles-grants branch from f59b894 to cfa8eb0 Compare March 28, 2025 16:07
@cameronperera cameronperera force-pushed the ICU-16411-roles-grants branch from cfa8eb0 to bba391a Compare March 28, 2025 16:38
calcaide
calcaide previously approved these changes Mar 28, 2025
View reviewed changes
Copy link
Collaborator

@calcaide calcaide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactor!! 🙌 left a couple of none blocking comments 😉

@priya-patel04 priya-patel04 mentioned this pull request Mar 28, 2025
Merged
6 tasks
Base automatically changed from ICU-16409-roles-list to main March 28, 2025 18:11
@cameronperera cameronperera dismissed calcaide’s stale review March 28, 2025 18:11

The base branch was changed.

@cameronperera cameronperera requested a review from calcaide March 28, 2025 22:09
laurenolivia
laurenolivia approved these changes Mar 31, 2025
View reviewed changes
Copy link
Collaborator

@laurenolivia laurenolivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cameronperera cameronperera merged commit 0f41a0a into main Mar 31, 2025
13 checks passed
@cameronperera cameronperera deleted the ICU-16411-roles-grants branch March 31, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calcaide calcaide calcaide approved these changes

@laurenolivia laurenolivia laurenolivia approved these changes

@priya-patel04 priya-patel04 priya-patel04 approved these changes

Assignees

@cameronperera cameronperera

Labels
addons admin desktop styles-addon ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cameronperera @calcaide @laurenolivia @priya-patel04