Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 💡 use test selector in groups/members route #2719

Merged
merged 5 commits into from
Mar 13, 2025
Merged

refactor: 💡 use test selector in groups/members route #2719

merged 5 commits into from
Mar 13, 2025

Conversation

DhariniJeeva
Copy link
Collaborator

Description

jira

Screenshots (if appropriate)

How to Test

Checklist

  • [ ] I have added before and after screenshots for UI changes
  • [ ] I have added JSON response output for API changes
  • [ ] I have added steps to reproduce and test for bug fixes in the description
  • [ ] I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • [x ] I have added tests that prove my fix is effective or that my feature works

@DhariniJeeva DhariniJeeva requested a review from a team as a code owner March 11, 2025 18:16
@vercel Vercel
Copy link

vercel bot commented Mar 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 4:41pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 4:41pm

calcaide
calcaide requested changes Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@calcaide calcaide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I left some comments 😉

calcaide
calcaide previously approved these changes Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@calcaide calcaide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! left a couple of none blocking comments 😉 Thanks for the refactor 🙌

hashicc
hashicc approved these changes Mar 13, 2025
View reviewed changes
Copy link
Collaborator

@hashicc hashicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These updated tests read so nicely. Thanks for doing the assert.dom() changes too 🕺

laurenolivia
laurenolivia approved these changes Mar 13, 2025
View reviewed changes
Copy link
Collaborator

@laurenolivia laurenolivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

priya-patel04
priya-patel04 approved these changes Mar 13, 2025
View reviewed changes
Copy link
Collaborator

@priya-patel04 priya-patel04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup!

@DhariniJeeva DhariniJeeva merged commit 878cb17 into main Mar 13, 2025
21 checks passed
@DhariniJeeva DhariniJeeva deleted the ICU-15485-groups-members-test branch March 13, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calcaide calcaide calcaide approved these changes

@cameronperera cameronperera cameronperera approved these changes

@laurenolivia laurenolivia laurenolivia approved these changes

@hashicc hashicc hashicc approved these changes

@priya-patel04 priya-patel04 priya-patel04 approved these changes

Assignees
No one assigned
Labels
admin ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DhariniJeeva @calcaide @cameronperera @laurenolivia @hashicc @priya-patel04