Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test selectors within auth-methods oidc test #2717

Merged

Conversation

calcaide
Copy link
Collaborator

Description

Refactor test selectors within auth-methods oidc test

🎟️ Jira ticket

How to Test

  • Run admin acceptance tests.

@calcaide calcaide self-assigned this Mar 10, 2025
@calcaide calcaide requested a review from a team as a code owner March 10, 2025 20:47
Copy link

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 0:03am
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 0:03am

cameronperera
cameronperera previously approved these changes Mar 12, 2025
Copy link
Collaborator

@cameronperera cameronperera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great, left a small non-blocking comment.

priya-patel04
priya-patel04 previously approved these changes Mar 12, 2025
Copy link
Collaborator

@priya-patel04 priya-patel04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Lgtm!

Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

Copy link
Collaborator

@laurenolivia laurenolivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@calcaide calcaide merged commit 706981c into main Mar 13, 2025
13 checks passed
@calcaide calcaide deleted the test-ICU-15464-refactor-test-selectors-auth-method-oidc branch March 13, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants