feat: document for hotplug nic #917
Conversation
Signed-off-by: Tim Liou <[email protected]>
github-actions
bot
requested review from
akashraj4261,
dariavladykina and
jillian-maroket
|
Signed-off-by: Tim Liou <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]> Signed-off-by: Tim Liou <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]> Signed-off-by: Tim Liou <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]> Signed-off-by: Tim Liou <[email protected]>
wheatdog
left a comment
wheatdog
left a comment
There was a problem hiding this comment.
@jillian-maroket Thanks for your previous review! I have checked the revised version. For hotunplug, I think VMs should have at least two interfaces.
Co-authored-by: Tim Liou <[email protected]> Signed-off-by: Jillian Maroket <[email protected]>
innobead
left a comment
innobead
left a comment
There was a problem hiding this comment.
LGTM, just one question.
P.S. It seems we rely only on migration-based hotplug: https://kubevirt.io/user-guide/network/hotplug_interfaces/#migration-based-hotplug.
|
|
||
| You cannot perform NIC hotplugging on virtual machines created in clusters running Harvester versions earlier than v1.7.0 _if the network interface's MAC address was not explicitly configured_. To enable this feature, you must restart those virtual machines. Restarting allows the system to automatically save the observed MAC addresses to the virtual machine's configuration. | ||
|
|
||
| In addition, virtual machines created by the [Harvester Node Driver](../rancher/node/node-driver.md) do not support NIC hotplugging and hotunplugging. |
There was a problem hiding this comment.
Does the Harvester Terraform provider support this? If not, we may also mention it.
There was a problem hiding this comment.
Good question. I think it's not supported.
Yes, currently only for migration-based hotplug. The reason for not supporting non-migration-based hotplug is documented in harvester/harvester#9498. |
Signed-off-by: Tim Liou <[email protected]>
3 participants
Problem:
Introduce the new Hotplug NIC feature and its limitation.
Solution:
Provide a dedicate documentation page and related images.
Related Issue(s):
harvester/harvester#7042
Test plan:
N/A
Additional documentation or context