Skip to content

Conversation

votdev
Copy link
Member

@votdev votdev commented Jun 3, 2025

Related Issue(s):

harvester/harvester#7987

@votdev votdev self-assigned this Jun 3, 2025
@Copilot Copilot AI review requested due to automatic review settings June 3, 2025 14:42
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the VirtualMachineImport documentation to include the new defaultDiskBusType field for specifying the disk bus type.

  • Added the defaultDiskBusType field with an example value in the YAML spec.
  • Included documentation on the usage of defaultDiskBusType for both VMware and OpenStack sources in the relevant docs file.

Copy link

github-actions bot commented Jun 3, 2025

Name Link
🔨 Latest commit 90c9628
😎 Deploy Preview https://68adac121d596ac9a8215d52--harvester-preview.netlify.app

@votdev votdev changed the title Specify disk bus type via defaultDiskBusType field in VirtualMachineImport docs: Specify disk bus type via defaultDiskBusType field in VirtualMachineImport Jun 3, 2025
ibrokethecloud
ibrokethecloud previously approved these changes Jun 5, 2025
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done. Sorry for the delay.

ibrokethecloud
ibrokethecloud previously approved these changes Jul 18, 2025
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@votdev votdev dismissed stale reviews from jillian-maroket and ibrokethecloud via ed57dca August 26, 2025 09:34
@votdev votdev force-pushed the issue_7987_DefaultDiskBusType branch from e61cbfd to ed57dca Compare August 26, 2025 09:34
@votdev
Copy link
Member Author

votdev commented Aug 26, 2025

@jillian-maroket Please re-approve the PR after a rebase was needed.

@votdev votdev merged commit 1c379e5 into harvester:main Aug 27, 2025
4 checks passed
@votdev votdev deleted the issue_7987_DefaultDiskBusType branch August 27, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants