Skip to content

fix pr tabs #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 18, 2025
Merged

fix pr tabs #1388

merged 5 commits into from
Apr 18, 2025

Conversation

ankormoreankor
Copy link
Collaborator

Fix for tabs at Pull Request page

Used NavLink in PR Tabs for the better accessibility, usability and performance

@CLAassistant
Copy link

CLAassistant commented Apr 3, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

netlify bot commented Apr 3, 2025

Deploy Preview for harness-xd-review ready!

Name Link
🔨 Latest commit 47399a4
🔍 Latest deploy log https://app.netlify.com/sites/harness-xd-review/deploys/67ffd1386ca66b00088d56e1
😎 Deploy Preview https://deploy-preview-1388--harness-xd-review.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 3, 2025

Deploy Preview for harness-design ready!

Name Link
🔨 Latest commit 47399a4
🔍 Latest deploy log https://app.netlify.com/sites/harness-design/deploys/67ffd1388b4c580008007382
😎 Deploy Preview https://deploy-preview-1388--harness-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ankormoreankor ankormoreankor force-pushed the fix-pr-tabs branch 2 times, most recently from 5321a20 to a358fd6 Compare April 9, 2025 14:53
@ankormoreankor ankormoreankor marked this pull request as ready for review April 9, 2025 14:54
@cjlee01
Copy link
Contributor

cjlee01 commented Apr 11, 2025

@ankormoreankor some conflicts now

@ankormoreankor ankormoreankor merged commit cb2d82d into main Apr 18, 2025
18 checks passed
@ankormoreankor ankormoreankor deleted the fix-pr-tabs branch April 18, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants