chore: remove Cargo.lock#89
Merged
Merged
Conversation
Libraries should not contain the lock file, as that does not change anything for the users, but may hide bugs for the developers of the library itself.
|
This is no longer the guidance from the Cargo team: https://blog.rust-lang.org/2023/08/29/committing-lockfiles/ |
Contributor
Author
|
@waywardmonkeys this is true - but is there a specific reason you want to keep the lock? Having lock means CI has to also test removing it and doing a build without it. |
Collaborator
|
We have (and intend to retain) a very small dependency graph, almost all of which we control. Given that and the desire to keep this mostly aligned with the fontations repo, I’m in favor of removing the lock file. We can restore it later if it becomes a problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Libraries should not contain the lock file, as that does not change anything for the users of the library, but may hide bugs for the maintainers of the library itself.
P.S. Note that this used to be part of #83