✨ feat(mq-lang): add dedent and common_indent builtins - #2332
Merged
Conversation
Adds common_indent(s) to compute the longest shared leading whitespace across a string's non-blank lines, and dedent(s) to strip it, normalizing blank lines to empty. Makes generating templates, quoted text, and code blocks easier to write.
harehare
force-pushed
the
feat/dedent-common-indent
branch
from
September 12, 2026 08:55
5ad86c5 to
2128c5a
Compare
Type narrowing ran before user-defined function call return types were propagated, so `let y = f(x) | if (y != None): ...` couldn't narrow away None on f's result, causing spurious NullablePropagation errors (e.g. in builtin.mq's dedent). Also guards dedent's prefix lookup with `!= None`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds common_indent(s) to compute the longest shared leading whitespace across a string's non-blank lines, and dedent(s) to strip it, normalizing blank lines to empty. Makes generating templates, quoted text, and code blocks easier to write.
Type of Change
Checklist
cargo fmtandcargo clippyand addressed any warningsjust test-alland all tests pass/docs, crateREADME.md) if neededAdditional Context