Skip to content

Check executable path exists before skipping download #2905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Check executable path exists before skipping download #2905

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d20434
Check executable path exists before skipping download
andrewgee Apr 30, 2025
3e23026
Merge branch 'master' into browser-fetcher-check-executable-path
kblok May 14, 2025
bb93d85
Merge branch 'master' into browser-fetcher-check-executable-path
kblok May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/PuppeteerSharp/BrowserFetcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@

if (!assemblyDirectory.Exists || !File.Exists(Path.Combine(assemblyDirectory.FullName, assemblyName)))
{
var assemblyLocation = assembly.Location;

Check warning on line 177 in lib/PuppeteerSharp/BrowserFetcher.cs

View workflow job for this annotation

GitHub Actions / Demo Project (windows-2022) 

PuppeteerSharp.BrowserFetcher.GetBrowsersLocation(): 'System.Reflection.Assembly.Location.get' always returns an empty string for assemblies embedded in a single-file app. If the path to the app directory is needed, consider calling 'System.AppContext.BaseDirectory'.

if (string.IsNullOrEmpty(assemblyLocation))
{
Expand Down Expand Up @@ -248,7 +248,7 @@

var outputPath = cache.GetInstallationDir(browser, Platform, buildId);

if (new DirectoryInfo(outputPath).Exists)
if (new FileInfo(GetExecutablePath(buildId)).Exists)
{
var existingBrowser = new InstalledBrowser(cache, browser, buildId, Platform);
existingBrowser.PermissionsFixed = RunSetup(existingBrowser);
Expand Down
Loading