Skip to content

Fix NULL ptr dereference on EC_POINT *point#1

Open
citypw wants to merge 1 commit intomasterfrom
ec_point-ptr-null-deref
Open

Fix NULL ptr dereference on EC_POINT *point#1
citypw wants to merge 1 commit intomasterfrom
ec_point-ptr-null-deref

Conversation

@citypw
Copy link
Copy Markdown

@citypw citypw commented Sep 19, 2024

Use non-usual params of pkcs11 module will trigger a null ptr deref bug. Fix it for openssl#25493

Checklist
  • documentation is added or updated
  • tests are added or updated

Comment thread crypto/ec/ec_oct.c Outdated
point_conversion_form_t form, unsigned char *buf,
size_t len, BN_CTX *ctx)
{
if ( point == NULL){
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space between the ) and the { please.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Plz review again!

@citypw citypw force-pushed the ec_point-ptr-null-deref branch from 39f3de8 to ae78e9b Compare September 19, 2024 21:59
@citypw citypw force-pushed the ec_point-ptr-null-deref branch from ae78e9b to f83d496 Compare September 19, 2024 22:23
Use non-usual params of pkcs11 module will trigger a null ptr deref bug. Fix it for openssl#25493

CLA: trivial
@citypw citypw force-pushed the ec_point-ptr-null-deref branch from f83d496 to 60538e0 Compare September 20, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants