Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Make ingress pathType "Exact" always override pathType "Prefix" #704

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phihos
Copy link

@phihos phihos commented Mar 5, 2025

Fixes #703.

We introduce a new map path-prefix-exact which contains exact match patterns for ingress pathType Prefix. From now on the map path-exact will only contain patterns from pathType Exact. The generated HAProxy config will check path-exact first, path-prefix-exact second and path-prefix third. That way pathType Exact always wins.

@phihos phihos force-pushed the 703 branch 2 times, most recently from 17d27f7 to eae6075 Compare March 10, 2025 17:40
@phihos phihos changed the title Make ingress pathType "Exact" always override pathType "Prefix" BUG: Make ingress pathType "Exact" always override pathType "Prefix" Mar 10, 2025
@phihos
Copy link
Author

phihos commented Mar 10, 2025

I fixed the broken e2e test and the commit message. Can somebody trigger the tests again?

@phihos
Copy link
Author

phihos commented Mar 10, 2025

The test TestMapUpdateSuite/Test_Update/Update now checks all three path-* map files.

@phihos
Copy link
Author

phihos commented Mar 11, 2025

The e2e test failure is odd. I ran ./deploy/tests/create.sh and then make e2e without any failure on my machine. What am I missing here?

@oktalz
Copy link
Member

oktalz commented Mar 12, 2025

@phihos I'll check, it wouldn't be the first time CI is misbehaving

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingress pathType "Prefix" can override pathType "Exact"
2 participants