BUG: Make ingress pathType "Exact" always override pathType "Prefix" #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phihos
force-pushed
the
703
branch
2 times, most recently
from
17d27f7 to
eae6075
Compare
phihos
changed the title
|
I fixed the broken e2e test and the commit message. Can somebody trigger the tests again? |
|
The test |
|
The e2e test failure is odd. I ran |
|
@phihos I'll check, it wouldn't be the first time CI is misbehaving |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #703.
We introduce a new map
path-prefix-exactwhich contains exact match patterns for ingress pathTypePrefix. From now on the mappath-exactwill only contain patterns from pathTypeExact. The generated HAProxy config will checkpath-exactfirst,path-prefix-exactsecond andpath-prefixthird. That way pathTypeExactalways wins.