fix: complies access scope validation to RFC8693 #4544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scope validation should support space separated values in credentials see https://datatracker.ietf.org/doc/html/rfc8693#name-scope-scopes-claim Co-authored-by: Vincent Hardouin <[email protected]>
|
Thanks for the PR! I have had a look at how Hapi handles scopes, and I don't agree that Hapi has an issue as such. The format of How are you applying it / what plugin are you using? If it provides a hook, you might be able to massage it in a callback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
RFC8693 on OAuth2.0 Token Exchange specifies that credentials scope may contain a space-separated list of scopes, however hapi’s access scope only supports either a string containing a single scope or an array containing a list of scopes.
Proposal
Allow using a string containing a space-separated list of scopes.