Skip to content

Vary shortcut by OS, automatically #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 30, 2024
Merged

Vary shortcut by OS, automatically #141

merged 7 commits into from
Jul 30, 2024

Conversation

fregante
Copy link
Collaborator

@fregante fregante commented Jul 29, 2024

@fregante fregante changed the title Vary show shortcut by OS, automatically Vary shortcut by OS, automatically Jul 29, 2024
@fregante fregante requested a review from hankxdev July 29, 2024 19:17
@@ -36,7 +36,7 @@
"hash": "1220702106584c8c90c0f41c486a3e0b"
},
"undoInfoMsg": {
"message": "在關閉這個窗口前你可以撤銷你的操作。 <br>在 Windows 或 Ubuntu 中按<kbd>ctrl+z</kbd>, macOS 中按<kbd>cmd+z</kbd>。",
"message": "在關閉這個窗口前你可以撤銷你的操作。 中按<kbd>Ctrl+Z</kbd>.",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the Chinese ones? In my languages I moved the shortcut in the middle of the sentence because it looked awkward at the end as just Press ctrl+z. Hide this

Screenshot 5

Other languages can stay as is

@fregante fregante merged commit 5c9b0f2 into main Jul 30, 2024
6 checks passed
@fregante fregante deleted the cmd-z branch July 30, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect OS and show exact shortcut
1 participant