Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Action generator to use RubyClassFile #288

Open
wants to merge 53 commits into
base: main
Choose a base branch
from
Open

Convert Action generator to use RubyClassFile #288

wants to merge 53 commits into from

Conversation

cllns
Copy link
Member

@cllns cllns commented Feb 18, 2025 •
edited
Loading

This builds on #284, which must be merged first.

Note that we can't get rid of the ActionContext yet because it's used in hanami/rspec.

It's hard to parse the changes for the spec file, but I was able to fix a specs where --skip-view was still generating a view

TODO:

cllns added 30 commits January 3, 2025 15:15
@cllns
Start conversion of View generator to use RubyFileWriter
ebfb990
@cllns
Finish conversion, though needs to be cleaned up
3b727b8
@cllns
Extract RubyClassFile to its own file
81d0a8d
@cllns
Refactor
eb7bf14
@cllns
More refactoring
2e019c7
@cllns
Remove un-used files
9f58101
@cllns
Clean up
a93cfaf
@cllns
Extract #key_parts private method
58e5850
@cllns
Fix @SInCE versions
33efdef
@cllns
Convert generating Action file in app to use RubyClassFile
e09ff34
@cllns
Use view generator in action, instead of re-implementing behavior
d253e02
@cllns
Add specs for preventing overwriting view class and template files
488fa49
@cllns
Refactor for clarity
bb115b2
@cllns
Convert generating Action file in slice to use RubyClassFile
abe584e
@cllns
Use view generator in slice action, too
9c7bca1
@cllns
Make generate method signatures identical
09a9763
@cllns
Remove ERB templates and code to render them
646e813
@cllns
Dry up key creation
dd0b320
@cllns
Extract bundled_views, in preparation for removing ActionContext
cbc988a
@cllns
Use namespace instead of context
8f9a09f
@cllns
Remove use of context
2a93e21
@cllns
Add base_path
9492b92
@cllns
Simplify logic with unless
ff50277
@cllns
Move route logic to conditional
7e9785e
@cllns
Finally combine methods into one
bfe1e59
@cllns
Remove url from generate_files parameters
33b9093
@cllns
Split into controller and action within generator
63a5b01
@cllns
Remove unused parameters, move slice check to command
2b83a00
@cllns
Simplify branches
5068e6a
@cllns
Separate generate methods
a2009e6
cllns added 21 commits February 17, 2025 21:42
@cllns
Store view generator as instance variable
c4316b9
@cllns
Extract insert_route helper method
c1a94ce
@cllns
Standardize on kwargs
56b20e3
@cllns
Convert insert_route to use key directly
55bc101
@cllns
Move skip_view check outside of generate_view
37e6749
@cllns
Rename to http_verb for clarity
0e6e87d
@cllns
Remove passing in 'slice', instead use the namespace
a21c05e
@cllns
More kwargs
eb6289c
@cllns
Use initializer aliases for more descriptive names
95741fa
@cllns
Move skip_route out of insert_route
cbc0b01
@cllns
Refactor insert_route
a9f0a7d
@cllns
Tidy up
cafd1d4
@cllns
Rename to http_method, add whitespace around params and options
3caf5ee
@cllns
Convert Generate Action to use base Generate Command
13aee91
@cllns
Remove unused kwarg
214e42d
@cllns
Reorder kwargs
9430ca0
@cllns
Remove un-used parameter
801bc8c
@cllns
Remove another un-used parameter
1d1d91e
@cllns
Rubocop fixes
c94d72d
@cllns
No bare double splats (only in 3.2+ and we need 3.1+ for now)
dfbf979
@cllns
Reorder methods in order of use
a82edbd
@cllns cllns requested a review from timriley February 18, 2025 20:34
Base automatically changed from expand-use-of-ruby-file-writer to main February 26, 2025 23:12
@cllns cllns mentioned this pull request Mar 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timriley timriley Awaiting requested review from timriley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cllns