fixed Matcher.hasXpath against multiple element #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to try and kick start hamcrest, so if you want to get it merged, please rebase from the branch |
nhojpatrick
force-pushed
the
master
branch
2 times, most recently
from
9bc653b to
e9f7fc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #323
323 mentioned that
Matcher.hasXpathcould have unexpected behavior when given an XML document with multiple elements of the same path. The reason is that current logic only evaluates a single element out of an XML doc. It is now fixed by letting the matcher first get all possible elements. Then if any of them matches, the result will be a match, otherwise failed.