Support Call::dynamic_shuffle for LUT in SVE2#9087
Open
stevesuzuki-arm wants to merge 2 commits intohalide:mainfrom
Open
Support Call::dynamic_shuffle for LUT in SVE2#9087stevesuzuki-arm wants to merge 2 commits intohalide:mainfrom
stevesuzuki-arm wants to merge 2 commits intohalide:mainfrom
Conversation
OptimizeShuffles pass is enabled in CodeGen_ARM for SVE2. - Detects gather load where index range is bounded within certain value e.g. Look Up Table - Transforms it into contiguous load + Call::dynamic_shuffle, which is lowered to TBL instruction by codegen. This is especially useful to vectorize with long vector in SME2 streaming mode where general form of gather load is unsupported. OptimizeShuffles is modified so that we can use it commonly between targets (for now, Hexagon and ARM SVE2).
Member
|
Does this happen only for allocations we've made ourselves, or also for input buffers? I see that if pads our own allocations but I don't see that it skips this for input buffers. I think hexagon might play fast and loose when it comes to reading out of bounds on input buffers by up to a vector. I fear in general this will fault if it crosses a page boundary though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OptimizeShuffles pass is enabled in CodeGen_ARM for SVE2.
This is especially useful to vectorize with long vector in SME2 streaming mode where general form of gather load is unsupported.
OptimizeShuffles is modified so that we can use it commonly between targets (for now, Hexagon and ARM SVE2).
Checklist