HLSL 6.0 ... 6.9 and GPUTexture for d3d12 by soufianekhiat · Pull Request #9077 · halide/Halide

soufianekhiat · 2026-03-25T23:29:29Z

Breaking changes

Add support for HLSL 6.0 ... 6.9
Add support for GPU Texture on d3d12compute

Details:

Emit "//HALIDE_D3D12_SM XX" on HLSL version and being parsed to avoid complex infrastructure just to get that version KISS.
Co-authored-by: Claude (all code formating, comments and mini_dxc.cpp was 100% written by Claude Opus 4.6)

Checklist

Tests added or updated (not required for docs, CI config, or typo fixes)
Documentation updated (if public API changed)
Python bindings updated (if public API changed)
Benchmarks are included here if the change is intended to affect performance.
Commits include AI attribution where applicable (see Code of Conduct)

soufianekhiat · 2026-03-25T23:30:06Z

Is that possible to have a maintainer trigger the CI for this one please?

alexreinking · 2026-03-26T12:14:54Z

We don't seem to have any d3d12compute coverage on the buildbots. I'll need to add that prior to reviewing/merging this.

soufianekhiat · 2026-03-26T12:20:06Z

We don't seem to have any d3d12compute coverage on the buildbots. I'll need to add that prior to reviewing/merging this.

Added this to tests HLSL 6.x features:
test/correctness/cross_compilation.cpp
https://github.com/halide/Halide/pull/9077/changes#diff-8155bdbbeeb25a66365bbd00273602683aa90a2f220c98dbaa8e15f6f988403e

alexreinking · 2026-03-27T02:53:34Z

I've modified the buildbots to test d3d12compute_sm65, which is the highest version both Windows bots support. We'll see how this goes! I notice that several features here are gated behind higher versions than that. I've tagged this dev_meeting so we can discuss a testing plan.

alexreinking · 2026-03-27T04:22:31Z

Many tests require strict_float... it seemed easy enough to implement following the precise hint and copying the Vulkan backend's approach to lowering. The only tricky business is that we need a different key than the given expression (or we'd need to implement a bunch of strict_OP intrinsics with precise arguments).

alexreinking · 2026-03-27T16:09:08Z

@soufianekhiat -- can you look at the codegen failures here? There seem to be two classes of bug:

Globals have clashing names. I'm not sure what the best resolution here is.
"as" casts are misspelled, e.g. asfloat32_t instead of asfloat

src/CodeGen_D3D12Compute_Dev.cpp

soufianekhiat · 2026-03-27T18:57:05Z

@soufianekhiat -- can you look at the codegen failures here? There seem to be two classes of bug:

Globals have clashing names. I'm not sure what the best resolution here is.

"as" casts are misspelled, e.g. asfloat32_t instead of asfloat

Do we have tests for codegen? I just run locally the one I think are relevant.

alexreinking · 2026-03-27T19:37:50Z

Do we have tests for codegen? I just run locally the one I think are relevant.

We don't have (many) compile-only tests... I'm just looking at the buildbot failures here; the issues are with invalid code being generated which is why I called them "codegen failures".

Also, I'm noticing that there's some signed/unsigned mismatch happening somewhere.

https://buildbot.halide-lang.org/master/#/builders/391/builds/385

src/CodeGen_D3D12Compute_Dev.cpp

alexreinking · 2026-03-28T13:47:55Z

@soufianekhiat - I've opened #9080 to test patches that are generally needed to fix the D3D12 backend, even for HLSL <6.0. That should provide a more stable foundation for this PR, which should be scoped to extending support to 6.0-6.9, rather than also including fundamental bug-fixes.

alexreinking · 2026-03-28T21:16:24Z

@soufianekhiat - the HLSL 5.1 fixes are in, so please rebase/merge with main.

soufianekhiat · 2026-03-28T21:51:13Z

Thanks

- Remove dead duplicate strict_float handler (bad merge artifact); the ScopedValue<emit_precise> approach is the correct implementation - Fix strict_fma to emit mad() for float/float16 (HLSL fma() is double-only; mad() is the correct float FMA intrinsic) - Add hlsl_reinterpret_name() helper so 'as' casts always emit the correct HLSL name (asfloat/asint/asuint/asfloat16) regardless of SM level; fixes asfloat32_t -> asfloat regression at SM >= 6.2 - Fix DXC global name clashes: prefix all arg names with the kernel name via RenameKernelArgs IRMutator; rename cbuffer per-kernel to avoid redeclaration errors in multi-kernel pipelines

slomp

A few observations and suggestions to get started.
(I will try to carve some time to review the runtime and code-gen properly, and to run everything locally).

test/correctness/cross_compilation.cpp

src/runtime/mini_dxc.h

soufianekhiat · 2026-04-01T09:55:53Z

@slomp here my systematic generation code:
https://gist.github.com/soufianekhiat/e3fa5aea28d14ed85722b6756e61af8d

alexreinking · 2026-04-01T11:54:15Z

@soufianekhiat -- looks like you forgot to update Target.h/.cpp while changing the naming scheme to hlsl_smXY. I just updated the buildbots to use that scheme going forward.

test/correctness/d3d12compute_strict_float.cpp

python_bindings/src/halide/halide_/PyEnums.cpp

src/Target.cpp

src/Target.h

alexreinking · 2026-04-01T19:21:56Z

Just FYI, the buildbot changes I made affect all PRs, so I can't keep them indefinitely. After this week, I'm going to need to revert them if this isn't merged, so you'll need a way to test this locally rather than relying on CI for iteration.

If there's something missing in your local setup that's making that hard, let me know and maybe I can help. I do want to see this land, I just need to keep the shared buildbot usage manageable.

…h, newtons_method}

soufianekhiat · 2026-04-01T20:23:13Z

Make the tests skip 64 bits for skip correctness_{gpu_mixed_shared_mem_types, math, newtons_method}, unsupported on dx12 (DXGI_FORMAT).

alexreinking requested review from derek-gerstmann and halidebuildbots March 26, 2026 08:15

alexreinking mentioned this pull request Mar 26, 2026

Report clang-tidy errors as GitHub annotations #9078

Merged

alexreinking added the dev_meeting Topic to be discussed at the next dev meeting label Mar 26, 2026

alexreinking added a commit to halide/build_bot that referenced this pull request Mar 27, 2026

Set d3d12compute_sm65 for testing halide/Halide#9077

749dead

soufianekhiat changed the title ~~HLSL 6.0 ... 6.9~~ HLSL 6.0 ... 6.9 and GPUTexture for d3d12 Mar 27, 2026

alexreinking reviewed Mar 27, 2026

View reviewed changes

src/CodeGen_D3D12Compute_Dev.cpp Outdated Show resolved Hide resolved

alexreinking reviewed Mar 27, 2026

View reviewed changes

src/CodeGen_D3D12Compute_Dev.cpp Outdated Show resolved Hide resolved

alexreinking reviewed Mar 28, 2026

View reviewed changes

src/CodeGen_D3D12Compute_Dev.cpp Outdated Show resolved Hide resolved

alexreinking mentioned this pull request Mar 28, 2026

Fix D3D12 compute #9080

Merged

5 tasks

soufianekhiat and others added 9 commits March 28, 2026 23:05

HLSL 6.0 ... 6.9

1148a72

Missing header

a333169

Fix JIT tests and add support for GPU Textures

8270fda

Add tests to validate HLSL 6.x features

9c4ddaa

Fix Clang Tidy.

b880b5c

Apply pre-commit auto-fixes

997ccbd

Add strict_float

3ad196f

Retrigger GHA

b650a16

Apply pre-commit auto-fixes

1925554

alexreinking and others added 3 commits March 28, 2026 23:06

Appease clang-tidy

1c99661

Implement strict float intrinsics for D3D12

2eba11b

soufianekhiat force-pushed the sk/hlsl_6 branch 2 times, most recently from 8872efc to 58223e6 Compare March 28, 2026 22:19

soufianekhiat added 4 commits March 28, 2026 23:22

Remove duplicate visit(const Shuffle *op)

2486419

Fix uint16 cast errors

37f4d92

Fix CL part 2

0096e32

Fix CI Part 3

7f1eb3f

soufianekhiat mentioned this pull request Mar 31, 2026

[Draft] D3D12Compute: HLSL 6 #8207

Closed

soufianekhiat added 2 commits March 31, 2026 19:20

CI++

768b61a

CI

7ed2dc6

alexreinking requested review from slomp and removed request for derek-gerstmann March 31, 2026 23:41

slomp requested changes Apr 1, 2026

View reviewed changes

test/correctness/cross_compilation.cpp Outdated Show resolved Hide resolved

src/runtime/mini_dxc.h Show resolved Hide resolved

shorter name for cross compilation and fix GUID

bc85661

soufianekhiat requested a review from slomp April 1, 2026 09:53

Fix comment and mismatch naming

8f17c7d

alexreinking reviewed Apr 1, 2026

View reviewed changes

test/correctness/d3d12compute_strict_float.cpp Outdated Show resolved Hide resolved

Too agressive for replace_all

1820ba3

slomp reviewed Apr 1, 2026

View reviewed changes

python_bindings/src/halide/halide_/PyEnums.cpp Outdated Show resolved Hide resolved

src/Target.cpp Outdated Show resolved Hide resolved

Rename + fix warning of implicit cast

90168c0

alexreinking reviewed Apr 1, 2026

View reviewed changes

src/Target.h Outdated Show resolved Hide resolved

rename

331f7ce

soufianekhiat added 2 commits April 1, 2026 22:00

Fix for correctness_mul_div_mod

16efab1

skip 64 bits buffer for: correctness_{gpu_mixed_shared_mem_types, mat…

463c8c6

…h, newtons_method}

Conversation

soufianekhiat commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking changes

Details:

Checklist

Uh oh!

soufianekhiat commented Mar 25, 2026

Uh oh!

alexreinking commented Mar 26, 2026

Uh oh!

soufianekhiat commented Mar 26, 2026

Uh oh!

alexreinking commented Mar 27, 2026

Uh oh!

alexreinking commented Mar 27, 2026

Uh oh!

alexreinking commented Mar 27, 2026

Uh oh!

Uh oh!

Uh oh!

soufianekhiat commented Mar 27, 2026

Uh oh!

alexreinking commented Mar 27, 2026

Uh oh!

Uh oh!

alexreinking commented Mar 28, 2026

Uh oh!

alexreinking commented Mar 28, 2026

Uh oh!

soufianekhiat commented Mar 28, 2026

Uh oh!

slomp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

soufianekhiat commented Apr 1, 2026

Uh oh!

alexreinking commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexreinking commented Apr 1, 2026

Uh oh!

soufianekhiat commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

soufianekhiat commented Mar 25, 2026 •

edited

Loading

alexreinking commented Apr 1, 2026 •

edited

Loading