Skip to content

Non-Silent Exit if Wrong Subroutine is Given #8665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FabianSchuetze wants to merge 4 commits into
base: main
Choose a base branch
from
+9 −3
Open

Non-Silent Exit if Wrong Subroutine is Given #8665

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b70026
don't exit silently in case of wrong name of subroutine
FabianSchuetze Jul 1, 2025
8a921df
spelling
FabianSchuetze Jul 1, 2025
e9e5378
Merge branch 'main' into verbose-exit-linear-algebra
alexreinking Mar 29, 2026
b9394e2
Print to stderr and exit
alexreinking Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions apps/linear_algebra/benchmarks/halide_benchmarks.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#include "clock.h"
#include "halide_blas.h"
#include "macros.h"
#include <iomanip>
#include <cstdlib>
#include <iostream>
#include <random>
#include <string>
Expand Down Expand Up @@ -82,6 +82,9 @@ struct BenchmarksBase {
bench_gemm_transB(size);
} else if (benchmark == "gemm_transAB") {
bench_gemm_transAB(size);
} else {
std::cerr << "subroutine: <" << benchmark << "> not known\n";
std::exit(1);
}
}

Expand Down Expand Up @@ -159,8 +162,8 @@ struct BenchmarksDouble : public BenchmarksBase<double> {

int main(int argc, char *argv[]) {
if (argc != 3) {
std::cout << "USAGE: halide_benchmarks <subroutine> <size>\n";
return 0;
std::cerr << "USAGE: halide_benchmarks <subroutine> <size>\n";
return 1;
}

std::string subroutine = argv[1];
Expand All @@ -172,6 +175,9 @@ int main(int argc, char *argv[]) {
BenchmarksFloat("Halide").run(subroutine, size);
} else if (type == 'd') {
BenchmarksDouble("Halide").run(subroutine, size);
} else {
std::cerr << "type: '" << type << "' not known. Expected 's' or 'd'.\n";
return 1;
}

return 0;
Expand Down
Loading