Skip to content

Conversation

VGPReys
Copy link
Contributor

@VGPReys VGPReys commented Sep 4, 2025

Checklist

  • Tests added for the new code
  • Documentation added for the code changes
  • Modifications / enhancements are reflected on the haddock3 user-manual
  • CHANGELOG.md is updated to incorporate new changes
  • Haddock3 version has been incremented in pyproject.toml
  • Does not break licensing
  • Does not add any dependencies, if it does please add a thorough explanation

Summary of the Pull Request

Modify file names in [contactmap] module.
Now cluster filenames are: cluster{rank}_modelX.
This new naming scheme is now more consistent with other modules dealing with clusters.

Related Issue

Closes #1359

@VGPReys VGPReys self-assigned this Sep 4, 2025
@VGPReys VGPReys added enhancement Improving something in the codebase m|contactmap labels Sep 4, 2025
@VGPReys VGPReys requested a review from a team September 4, 2025 08:40
@VGPReys VGPReys marked this pull request as ready for review September 4, 2025 08:40
pyproject.toml Outdated
@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "haddock3"
version = "2025.8.1"
version = "2025.8.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several pull requests in // - will have to see which version should be used here - also if we merge #1369 first, the month should become 9.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should indeed become 2025.8.2 - and some conflicts to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving something in the codebase m|contactmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency in cluster naming
2 participants