Interactive eval #1351
Draft
Interactive eval #1351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgefst
force-pushed
the
georgefst/eval-mode
branch
from
37ea7ef to
3dbc461
Compare
Signed-off-by: George Thomas <[email protected]>
will allow other uses and extra constructors Signed-off-by: George Thomas <[email protected]>
unused for now... Signed-off-by: George Thomas <[email protected]>
separate draft PR as optional WIP follow-up to the other mobile tweaks? this is nice, esp. on mobile, but we should really separate the notions of "eval takes up whole app" and "app is actually fullscreen" and for the latter we should also handle browser events, i.e. that the user can exit fullscreen without using Primer UI (e.g. Esc key in Firefox) JSaddle code needs clean up - error handling, not using `eval` etc. implementation is also slightly messy at call site ideally, mobile browsers would just have a generic option for this, like pressing f11 on desktop... Opera Mini has this but it's clunky Signed-off-by: George Thomas <[email protected]>
Signed-off-by: George Thomas <[email protected]>
hmm, maybe this doesn't really fit with original philosophy for this module, which is that everything is upstreamable somewhere... Signed-off-by: George Thomas <[email protected]>
Signed-off-by: George Thomas <[email protected]>
… stuff like this Signed-off-by: George Thomas <[email protected]>
still need to improve comment on `history ::` note that we no longer show the timeout error new UX kind of assumes timing out is fine and normal plus it's obvious whether an expression has finished eval by whether there are redexes highlighted (at least for small expressions) and anyway, the old `"No selection for eval"` message was never actually shown, since we mistakenly didn't show the `error` field when `expr` was `Nothing`. we still show `"No definition selected for evaluation"` now, so nothing has been lost with this change UX a bit weird for now... requires further thought e.g. changing an eval opt resets the interactive-eval state, i.e. back to fulleval output explain setting of `stepLimit = 0` Signed-off-by: George Thomas <[email protected]>
Signed-off-by: George Thomas <[email protected]>
georgefst
force-pushed
the
georgefst/eval-mode
branch
from
3dbc461 to
c83de10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.