Skip to content

Fixed minio image upload InvalidBucketNameError error #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed minio image upload InvalidBucketNameError error #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e6457e
Add environment CMD_S3_BUCKET to minio attributes
abola Dec 24, 2021
5273bd9
Add attribute codimd.imageUpload.minio.bucket
abola Dec 24, 2021
06c1516
Add attribute codimd.imageUpload.minio.bucket
abola Dec 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/codimd/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ If you want use ingress, please set `service.type` to be `ClusterIP`
| codimd.imageUpload.minio.port | The minio port | `nil` |
| codimd.imageUpload.minio.accessKey | The minio access key | `nil` |
| codimd.imageUpload.minio.secretKey | The minio secret key | `nil` |
| codimd.imageUpload.minio.bucket | The minio bucket name | `nil` |
| codimd.imageUpload.s3.endpoint | The AWS s3 endpoint | `nil` |
| codimd.imageUpload.s3.region | The AWS s3 region | `nil` |
| codimd.imageUpload.s3.accessKeyId | The AWS s3 access key | `nil` |
Expand Down
3 changes: 2 additions & 1 deletion charts/codimd/templates/image-upload-secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ stringData:
CMD_MINIO_ENDPOINT: {{ default "" .Values.codimd.imageUpload.minio.endpoint | quote }}
CMD_MINIO_SECURE: {{ default "true" .Values.codimd.imageUpload.minio.secure | quote }}
CMD_MINIO_PORT: {{ default "" .Values.codimd.imageUpload.minio.port | quote }}
CMD_S3_BUCKET: {{ default "" .Values.codimd.imageUpload.minio.bucket | quote }}
{{ end }}
{{ end }}

Expand All @@ -47,4 +48,4 @@ stringData:
CMD_AZURE_CONTAINER: {{ default "" .Values.codimd.imageUpload.azure.container | quote }}
{{ end }}
{{ end }}
{{ end }}
{{ end }}
1 change: 1 addition & 0 deletions charts/codimd/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ codimd:
# port:
# accessKey:
# secretKey:
# bucket:
# s3:
# endpoint:
# region:
Expand Down