Skip to content

codimd.extraEnvironmentVariablesFrom to support passing {configMap,secretKey}Ref as environment variables #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

codimd.extraEnvironmentVariablesFrom to support passing {configMap,secretKey}Ref as environment variables #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7938b6
extraEnvironmentVariablesFrom: env.vars from configMaps/secrets
SamuAlfageme Jun 15, 2021
3b0ce79
Add 'artifacthub.io' annotations for changelog and sec.scanning
SamuAlfageme Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion charts/codimd/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,15 @@ kubeVersion: ">=1.14.0-0"

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.1.10
version: 0.1.11

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 2.3.2

annotations:
artifacthub.io/changes: |
- "Add 'codimd.extraEnvironmentVariablesFrom' to enable passing configMap/secret-KeyRef(s) as environment variables to CodiMD"
artifacthub.io/images: |
- name: hackmd
image: nabo.codimd.dev/hackmdio/hackmd:2.3.2
2 changes: 2 additions & 0 deletions charts/codimd/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,8 @@ If you want use ingress, please set `service.type` to be `ClusterIP`
| codimd.markdown.useHardBreak | | `true` |
| codimd.markdown.linkifyHeaderStyle | | `keep-case` |
| codimd.extraEnvironmentVariables | Extra environment variable for CodiMD container | `{}` |
| codimd.extraEnvironmentVariablesFrom | List of extra environment variable(s) in YAML for CodiMD container, useful for `{configMap,secret}KeyRef` | `[]` |

### CodiMD Authentication Method parameters

| Parameter | Description | Default |
Expand Down
3 changes: 3 additions & 0 deletions charts/codimd/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,9 @@ spec:
value: {{ $val | quote }}
{{ end }}
{{ end }}
{{- if .Values.codimd.extraEnvironmentVariablesFrom }}
{{- toYaml .Values.codimd.extraEnvironmentVariablesFrom | nindent 12 }}
{{- end }}
envFrom:
- secretRef:
name: {{ template "codimd.shortName" . }}-auth-env
Expand Down
12 changes: 12 additions & 0 deletions charts/codimd/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,18 @@ codimd:
extraEnvironmentVariables: {}
# CMD_LOGLEVEL: info

extraEnvironmentVariablesFrom: []
# - name: ENV_FROM
# valueFrom:
# configMapKeyRef:
# name: configmap
# key: configmap_key
# - name: SECRET_ENV_FROM
# valueFrom:
# secretKeyRef:
# name: secret
# key: secret_key

## automatically check new version
versionCheck: true

Expand Down