Skip to content

Make resource requests and limits of codimd container configurable #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make resource requests and limits of codimd container configurable #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion charts/codimd/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ If you want use ingress, please set `service.type` to be `ClusterIP`
| codimd.securityContext.runAsGroup | Group ID for the CodiMD container | `1500` |
| codimd.securityContext.runAsUser | User ID for the CodiMD container | `1500` |
| codimd.securityContext.fsGroup | Group ID for the CodiMD filesystem | `1500` |
| codimd.securityContext.runAsNonRoot | Run non root in CodiMD container | `trrue` |
| codimd.securityContext.runAsNonRoot | Run non root in CodiMD container | `true` |
| codimd.resources | Resource Requests and Limits for the CodiMD container | `nil` |
| codimd.connection.domain | The domain name your service will be hosted. | `nil` |
| codimd.connection.urlAddPort | Set to assign port for URL. (You don’t need this for ports 80 or 443. This only works when domain is set) | `false` |
| codimd.connection.protocolUseSSL | Use SSL protocol for resources path (applied only when domain is set). | `false` |
Expand Down
2 changes: 2 additions & 0 deletions charts/codimd/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,8 @@ spec:
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 2
resources:
{{- toYaml .Values.codimd.resources | nindent 12 }}
restartPolicy: Always
{{ if .Values.codimd.imageStorePersistentVolume.enabled }}
volumes:
Expand Down
13 changes: 12 additions & 1 deletion charts/codimd/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,18 @@ codimd:
runAsUser: 1500
fsGroup: 1500
runAsNonRoot: true

##
## Resource limits and requests
## ref: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
##
# resources:
# limits:
# cpu: 500m
# memory: 512Mi
# requests:
# cpu: 100m
# memory: 128Mi
resources: {}
##
## connection setting
##
Expand Down