Feat/create application review #1032
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <[email protected]>
* Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <[email protected]>
* Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <[email protected]>
* Add 3rd checkbox to Terms and Conditions #1010 * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <[email protected]> * Added Jamie's changes for MLH checkbox, fixed merge conflicts. * fixed dumb rebase error --------- Co-authored-by: Tavi Pollard <[email protected]> Co-authored-by: allennatang <[email protected]> Co-authored-by: Tavi Pollard <[email protected]>
…#1008) * change-mchacks12 * change-mchacks12 * Remove Netlify link from README * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <[email protected]> * Fix/fixed phone number input (#1006) * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <[email protected]> * add success message and reset fields after an invite is successfully sent * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <[email protected]> * Add 3rd checkbox to Terms and Conditions (#1012) * Add 3rd checkbox to Terms and Conditions #1010 * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <[email protected]> * Added Jamie's changes for MLH checkbox, fixed merge conflicts. * fixed dumb rebase error --------- Co-authored-by: Tavi Pollard <[email protected]> Co-authored-by: allennatang <[email protected]> Co-authored-by: Tavi Pollard <[email protected]> * change-mchacks12 --------- Co-authored-by: Mika Vohl <[email protected]> Co-authored-by: Joshua Zhou <[email protected]> Co-authored-by: Joshua Zhou <[email protected]> Co-authored-by: Tavi Pollard <[email protected]> Co-authored-by: allennatang <[email protected]> Co-authored-by: Tavi Pollard <[email protected]>
* Add 3rd checkbox to Terms and Conditions #1010 * Update Grad Years in Filter * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <[email protected]> * Clear the fields and add success message after sending account invite (#1008) * change-mchacks12 * change-mchacks12 * Remove Netlify link from README * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <[email protected]> * Fix/fixed phone number input (#1006) * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <[email protected]> * add success message and reset fields after an invite is successfully sent * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <[email protected]> * Add 3rd checkbox to Terms and Conditions (#1012) * Add 3rd checkbox to Terms and Conditions #1010 * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <[email protected]> * Added Jamie's changes for MLH checkbox, fixed merge conflicts. * fixed dumb rebase error --------- Co-authored-by: Tavi Pollard <[email protected]> Co-authored-by: allennatang <[email protected]> Co-authored-by: Tavi Pollard <[email protected]> * change-mchacks12 --------- Co-authored-by: Mika Vohl <[email protected]> Co-authored-by: Joshua Zhou <[email protected]> Co-authored-by: Joshua Zhou <[email protected]> Co-authored-by: Tavi Pollard <[email protected]> Co-authored-by: allennatang <[email protected]> Co-authored-by: Tavi Pollard <[email protected]> --------- Co-authored-by: Tavi Pollard <[email protected]> Co-authored-by: allennatang <[email protected]> Co-authored-by: Mika Vohl <[email protected]> Co-authored-by: Joshua Zhou <[email protected]> Co-authored-by: Joshua Zhou <[email protected]> Co-authored-by: Tavi Pollard <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
|
closing because of old commits included. will make new review with rebased version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets:
List of changes:
Type of change:
Please delete options that aren't relevant.
How did you do this?
How to test:
Click on a hacker's "See more" and enter a reviewer status and name/comments. Wait a second or two, then click on the reload button. The changes should now be saved, and the hackers' "See more" should be updated as well as the "Review Status" column in the table (Note: the "Review Status" column only checks if the actual Reviewer Status is changed (AKA not none) or not; the name and comments do not matter).
Filter the table for hackers with 0/1/2 "Review Status".
Questions:
PR Checklist:
developbranch (before testing)Screenshots: