Add Docker to Railstats LA Technologies - #8732
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 8/14 |
kimberly-WY
left a comment
There was a problem hiding this comment.
Good improvement overall. One edge case: empty string vs null aren't treated the same downstream — might need a normalization step.
Abigail-Diaz
left a comment
There was a problem hiding this comment.
Hello @palak-hellowrld,
Everything looks good.
- Linked issue is present
- No errors during local testing
- Visual changes are consistent with the requirements in the original issue
- Branches are correctly set
Great job! :)
Thanks for the review @kimberly-WY ! Just want to clarify, my change only added 'Docker' to the technologies list in the front matter. Could you point me to where the empty string/null concern applies here? Want to make sure I address the right thing. |
Fixes #8658
What changes did you make?
technologieslist in_projects/metro-ontime.mdWhy did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
No before screenshot (forgot to save the screenshot). The technologies field simply did not include Docker yet.Visuals after changes are applied