fix(docker): update Node versions to 24 and mount shared directory#2150
Open
trillium wants to merge 2 commits intohackforla:developmentfrom
Open
fix(docker): update Node versions to 24 and mount shared directory#2150trillium wants to merge 2 commits intohackforla:developmentfrom
trillium wants to merge 2 commits intohackforla:developmentfrom
Conversation
Dockerfiles were pinned to node:18.12.0 while .nvmrc specifies Node 24. Also mount the shared/ directory in docker-compose so the backend can resolve ../../shared/authorizationUtils at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.nvmrcshared/directory in docker-compose so backend can resolve../../shared/authorizationUtilsat runtimeChanged files
backend/Dockerfile.dev— node:18.12.0 → node:24-alpinebackend/Dockerfile.api— node:18.12.0 → node:24-alpine (all 3 stages)client/Dockerfile.dev— node:18-alpine → node:24-alpineclient/Dockerfile.client— node:20-alpine → node:24-alpineclient/Dockerfile.prod— node:20-alpine → node:24-alpinedocker-compose.yml— add./shared:/srv/sharedvolume to backend serviceTest plan
docker compose up backend client --buildand verify both services startCannot find module '../../shared/authorizationUtils'.nvmrc(24)