Refactor first_login email to onboarded
#11766
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
|
||
| after_update :update_stripe_cardholder, if: -> { phone_number_previously_changed? || email_previously_changed? } | ||
|
|
||
| after_update_commit :send_onboarded_email, if: -> { full_name_previously_changed? && full_name_before_last_save.blank? && full_name.present? } |
There was a problem hiding this comment.
This is a bit brittle in the case that we change what it means to be onboarded.
Can we abstract some of this logic out into a method that plays well with our existing onboarding? method?
Lines 315 to 318 in ab1d1c4
| if user.user_sessions.size == 1 | ||
| UserSessionMailer.first_login(user:).deliver_later | ||
| elsif fingerprint.present? && user.user_sessions.excluding(self).where(fingerprint:).none? | ||
| if user.user_sessions.size > 1 && fingerprint.present? && user.user_sessions.excluding(self).where(fingerprint:).none? |
There was a problem hiding this comment.
This comment is not directly related to this PR. However, maybe we should explicitly wrap this in a !impersonated?.
This isn't completely necessary since impersonated sessions do not have fingerprints. However, I do still believe it's good to have this condition explicitly documented in the code.
No, honestly, it doesn't make sense to me why we'd email them this email. We can have a job that does that every 10 minutes but just feels weird to send someone an email they don't seem to want. |
Closes #11708 by factoring this email to only go out when a user is "onboarded" which we define as the user having a full name.