Skip to content

Conversation

@jjolly
Copy link

@jjolly jjolly commented Sep 23, 2025

Pull Request

Description

Fixes to help connect to a Ollama instance remotely hosted

Type of Change

  • πŸ› Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • πŸ”§ Refactoring (no functional changes)
  • ⚑ Performance improvement
  • πŸ§ͺ Test improvements
  • πŸ”’ Security improvement
  • πŸ—οΈ Infrastructure/tooling change

Related Issues

Changes Made

  • Install checks OLLAMA_HOST, validates the host exists, pulls the default models, and adds ollama_host to the config
  • Properly order the config files when retrieving config data
  • Passes the configured Ollama host to OllamaAPIClient when initialized

Testing

  • Unit tests pass locally (pytest tests/unit/)
  • Integration tests pass locally (pytest tests/integration/)
  • Manual testing completed
  • Added new tests for new functionality
  • All existing tests still pass

Test Evidence

Code Quality

  • Code follows the project style guidelines (black, isort)
  • Code passes linting (flake8)
  • Type checking passes (mypy)
  • Security scan passes (bandit)
  • No new security vulnerabilities introduced

Quality Check Commands

# Run these commands to verify code quality
make format-check  # or: black --check ocode_python/ && isort --check-only ocode_python/
make lint         # or: flake8 ocode_python/ && mypy ocode_python/
make security     # or: bandit -r ocode_python/

Documentation

  • Updated relevant documentation
  • Added docstrings for new functions/classes
  • Updated CLAUDE.md if development process changed
  • Updated README.md if user-facing changes
  • Added/updated examples if applicable

Breaking Changes

  • None

OR

  • Updated version number appropriately
  • Added migration guide or notes
  • Updated changelog/release notes

Performance Impact

  • No performance impact
  • Performance improvement (describe)
  • Minor performance impact (acceptable)
  • Significant performance impact (requires discussion)

Security Considerations

  • No security impact
  • Security improvement
  • Requires security review
  • New security considerations documented

Deployment Notes

  • No special deployment requirements
  • Requires environment variable changes
  • Requires configuration updates
  • Requires migration steps

Screenshots/Examples

Checklist

  • I have read the CONTRIBUTING.md guide
  • My code follows the project's coding standards
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Additional Notes


For Maintainers

  • Ready for review
  • Requires design discussion
  • Requires breaking change approval
  • Requires security review
  • Ready to merge

Have the install shell script check the remote host when OLLAMA_HOST is
defined in the environment. Also download the default models when the
host is verified.
The _load_all_configs function in ConfigManager is creating a list of configs to process in reverse order. This list was being passed to _merge_configs, which was reversing the already-reverse-ordered list.

This change removes the reversal in _merge_configs
The OCodeEngine was creating the OllamaAPIClient without specifying the Ollama host. This is now retrieved from the config and passed into the OllamaAPIClient init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant