Update actions to latest version #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workflow still used `actions/cache@v2` which will [stop working in February](https://github.blog/changelog/2024-09-16-notice-of-upcoming-deprecations-and-changes-in-github-actions-services/). `actions/cache` is also no longer required, because `actions/setup-node` handles caching dependencies. The other used actions are also still using node 12 and were automatically running as node 20, which might break them in weird ways that are difficult to detect. Upgrading `codecov/codecov-action` from `v2` to `v5` introduced a few major changes, one of which is that `v4` now always requires a token, but `v5` relaxed that again. I'm not sure if you have a token setup already, or if you need to change anything in your codecov settings. The Migration Guide is here: https://github.com/codecov/codecov-action/tree/v5?tab=readme-ov-file#v5-release
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
===========================================
- Coverage 100.00% 98.57% -1.43%
===========================================
Files 14 15 +1
Lines 164 210 +46
Branches 51 68 +17
===========================================
+ Hits 164 207 +43
- Misses 0 3 +3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Thanks! TIL you dont need the extra cache action anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow still used
actions/cache@v2which will stop working in February.actions/cacheis also no longer required, becauseactions/setup-nodehandles caching dependencies.The other used actions are also still using node 12 and were automatically running as node 20, which might break them in weird ways that are difficult to detect.
Upgrading
codecov/codecov-actionfromv2tov5introduced a few major changes, one of which is thatv4now always requires a token, butv5relaxed that again. I'm not sure if you have a token setup already, or if you need to change anything in your codecov settings. The Migration Guide is here: https://github.com/codecov/codecov-action/tree/v5?tab=readme-ov-file#v5-release