Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add value to owned items if filter is true and fix tests. #27

Merged
merged 9 commits into from
Nov 14, 2024

Conversation

Ecmelt
Copy link
Contributor

@Ecmelt Ecmelt commented Nov 7, 2024

No description provided.

Copy link
Member

@queicherius queicherius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, please check the comments and add a test for this change

src/cheapestTree.ts Outdated Show resolved Hide resolved
src/cheapestTree.ts Outdated Show resolved Hide resolved
src/cheapestTree.ts Show resolved Hide resolved
tests/__snapshots__/calculateTreeCraftFlags.spec.ts.snap Outdated Show resolved Hide resolved
@Ecmelt Ecmelt force-pushed the add-owned-item-value branch 2 times, most recently from 95a52c2 to 0f359dc Compare November 11, 2024 10:00
src/cheapestTree.ts Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@Ecmelt
Copy link
Contributor Author

Ecmelt commented Nov 12, 2024

@queicherius the test fails with Argument of type 'true' is not assignable to parameter of type 'false'.

@queicherius queicherius merged commit a3cade1 into master Nov 14, 2024
2 checks passed
@queicherius queicherius deleted the add-owned-item-value branch November 14, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants