Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Build Code parsing for SotO #9

Merged
merged 7 commits into from
Sep 4, 2023

Conversation

darthmaim
Copy link
Contributor

@darthmaim darthmaim commented Sep 4, 2023

  • Added build code encoding/decoding for selectedWeapons and selectedSkillVariants
  • Added test case for new build code
  • Added tests to ensure old codes without those features are still parsed correctly
  • Updated dependencies to fix build
  • Update types to fix decode return type
    (see Add correct types for gw2e-chat-codes GW2Treasures/gw2treasures.com#233)
  • Update encode type to only allow correct data for specified build type

ref: https://discord.com/channels/384735285197537290/384735523521953792/1145839295849046077

@darthmaim
Copy link
Contributor Author

darthmaim commented Sep 4, 2023

Btw @queicherius, is there a reason that the id is optional and allows for strings? encode('item', {}) or encode('item, 'foo') should fail when compiling already in my opinion.

@queicherius
Copy link
Member

queicherius commented Sep 4, 2023

Awesome, thank you for this huge effort!

Is there a reason that the id is optional and allows for strings?

I think that was a remainder of refactoring to TS and not intended.

Copy link
Member

@queicherius queicherius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@queicherius queicherius merged commit fabb9b0 into gw2efficiency:master Sep 4, 2023
@queicherius
Copy link
Member

Published as 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants