Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve types #11

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

darthmaim
Copy link
Contributor

  • Remove string from skin and upgrades types
  • Remove some type assertions
  • Remove @ts-expect-error and replace with as any, because ts will never report any other errors with that line in the future

Copy link
Member

@queicherius queicherius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@queicherius queicherius merged commit 27d4006 into gw2efficiency:master Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants