Added extensions load and unload command. #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 30, 2021 13:32
…e in utils, added extensions command for loading, unloading and reloading extensions
Shivansh-007
approved these changes
Feb 4, 2021
Shivansh-007
suggested changes
Feb 4, 2021
vivekashok1221
requested changes
Feb 5, 2021
|
@codephile1221 @Shivansh-007 |
Shivansh-007
suggested changes
Feb 7, 2021
| #ROLES | ||
| STEERING_COUNCIL="" | ||
| SUPREME_CUCUMBER="" | ||
| LORDS="" |
There was a problem hiding this comment.
Missing new line in here
There was a problem hiding this comment.
A new line after LORDS="" is missing.
| await ctx.channel.send(messages) | ||
|
|
||
|
|
||
| def manage( |
There was a problem hiding this comment.
PEP 8: E303 too many blank lines.
|
|
||
|
|
||
| def setup(bot: commands.Bot) -> None: | ||
| bot.add_cog(Extensions(bot)) |
There was a problem hiding this comment.
PEP 8: W292 no newline at end of file
Comment on lines
+113
to
+115
| extensions = [ ext for ext in extension.EXTENSIONS | ||
| if ext not in UNLOAD_BLACKLIST | ||
| ] |
There was a problem hiding this comment.
PEP 8: E124 closing bracket does not match visual indentation
| return | ||
|
|
||
| if '*' in extensions: | ||
| extensions = [ ext for ext in extension.EXTENSIONS |
There was a problem hiding this comment.
PEP 8: E201 whitespace after '['
| await ctx.channel.send(messages) | ||
|
|
||
| @extension_group.command(name="unload", aliases=["ul"]) | ||
| async def unloading(self, ctx: commands.Cog, *extensions: Extension) -> None: |
There was a problem hiding this comment.
Suggested change
| async def unloading(self, ctx: commands.Cog, *extensions: Extension) -> None: | |
| async def unloading(self, ctx: commands.Context, *extensions: Extension) -> None: |
| @@ -1,6 +1,7 @@ | |||
| import logging | |||
There was a problem hiding this comment.
Unused import statement 'import logging'
Suggested change
| import logging |
|
It doesn't seem like this will ever be merged. There's a new PR for extension management commands now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15
Moved bot.run, load_extensions to main.py. Added an extension file in utils, added extensions command for loading, unloading and reloading extensions.
