Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaderboard export improvements #1546

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Leaderboard export improvements #1546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eaa67a9
Export all users from leaderboard
TomiOhl Nov 15, 2024
e7e2381
copy(footer): remove unnecessary comma
TomiOhl Nov 15, 2024
38a754b
Adjust export button tooltip
TomiOhl Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/api/leaderboard/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export async function GET(req: NextRequest) {
Object.fromEntries(req.nextUrl.searchParams)
)
const leaderboardRequest = new URL(
`/v2/guilds/${guildId}/points/${pointsId}/leaderboard?forceRecalculate=true`,
`/v2/guilds/${guildId}/points/${pointsId}/leaderboard?forceRecalculate=true&isAllUser=true`,
env.NEXT_PUBLIC_API
)

Expand Down
12 changes: 11 additions & 1 deletion src/components/[guild]/leaderboard/LeaderboardPointsSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,17 @@ const LeaderboardPointsSelector = () => {
<>
<RecalculateLeaderboardButton size="ICON" />
<Divider orientation="vertical" h={8} />
<Tooltip label="Loading might take a while, depeding on member count">
<Tooltip
label={
<>
Export leaderboard
<br />
<span style={{ fontSize: "0.9em", opacity: 0.8 }}>
Loading might take a while depending on member count
</span>
</>
}
>
<a
download
href={`/api/leaderboard?guildId=${guildId}&pointsId=${router.query.pointsId}`}
Expand Down
2 changes: 1 addition & 1 deletion src/components/common/Layout/components/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const Footer = (): JSX.Element => (
<Icon as={ArrowSquareOut} ml="1" />
</Link>
<Text as="span" colorScheme="gray" lineHeight={2}>
{`, and built on the `}
{` and built on the `}
</Text>
<Link href="https://www.npmjs.com/package/@guildxyz/sdk" isExternal>
Guild SDK
Expand Down
Loading