Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve circular imports by reorganizing /src/rewards #1418

Merged
merged 6 commits into from
Jul 30, 2024

Conversation

dominik-stumpf
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
guild-xyz ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 10:17am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
guild-xyz-storybook ⬜️ Ignored (Inspect) Jul 30, 2024 10:17am

Copy link
Collaborator

@BrickheadJohnny BrickheadJohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just please clean up the unnecessary comments (e.g. in AccessedGuildPlatformCard.tsx & src/rewards/types.ts files) before merging it. 😉

@dominik-stumpf dominik-stumpf merged commit 6850003 into main Jul 30, 2024
7 checks passed
@dominik-stumpf dominik-stumpf deleted the reorganize-rewards branch July 30, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants