Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve circular dependencies #1414

Merged
merged 13 commits into from
Jul 29, 2024
Merged

resolve circular dependencies #1414

merged 13 commits into from
Jul 29, 2024

Conversation

dominik-stumpf
Copy link
Contributor

@dominik-stumpf dominik-stumpf commented Jul 26, 2024

This PR intends to fix all remaining circular imports

Note: On the first commit, the loop is broken by removed module, which could cause issue in the current requirement creation flow, although it doesn't break anything. This was the easiest way of doing this as the SelectRolePanel requires all components.

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
guild-xyz ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 11:52am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
guild-xyz-storybook ⬜️ Ignored (Inspect) Jul 29, 2024 11:52am

Copy link
Collaborator

@BrickheadJohnny BrickheadJohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dominik-stumpf dominik-stumpf merged commit cf25a5d into main Jul 29, 2024
6 of 7 checks passed
@dominik-stumpf dominik-stumpf deleted the resolve-circular-deps branch July 29, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants