-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add existing rewards to a guild #1402
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dovalid
approved these changes
Jul 18, 2024
dovalid
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you about adding the settings modal to the AddSolutionModal, I'm sure we're good this way for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users sometimes do not notice the rewards which they already use in their guild in the quick add section, so we display these rewards in components like
DiscordGuildSetup
too. We forgot to handle & test this case in a recent refactor, so this feature caused some errors. This PR aims to fix the issue by checking if aguildPlatform
with a specificplatformGuildId
already exists in the guild, and optionally adding aguildPlatformId
field to therolePlatform
in that case, so our API knows that we shouldn't try to create a newguildPlatform
in our DB, but we should re-use an existing one. I added a longer comment about it too. We also display a settings modal when the user wants to add an existing reward to a role. I haven't added this modal to theAddSolutionsModal
, because in my opinion users will probably click on that button if they want to add a brand new reward to their guild, but let me know if we should add it there too.As a side quest, I completely removed some unused files & added the new solutions modal to the group page too.