Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve circular dependencies #1399

Merged
merged 13 commits into from
Jul 20, 2024
Merged

resolve circular dependencies #1399

merged 13 commits into from
Jul 20, 2024

Conversation

dominik-stumpf
Copy link
Contributor

@dominik-stumpf dominik-stumpf commented Jul 17, 2024 •
edited
Loading

This PR resolves 6 circular import errors. Loops were addressed separately by each dcd commit.

@vercel Vercel
Copy link

vercel bot commented Jul 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
guild-xyz ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 8:59pm
guild-xyz-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 8:59pm

@vercel vercel bot temporarily deployed to Preview – guild-xyz-storybook July 17, 2024 08:29 Inactive
@vercel vercel bot temporarily deployed to Preview – guild-xyz-storybook July 17, 2024 08:36 Inactive
@vercel vercel bot temporarily deployed to Preview – guild-xyz-storybook July 17, 2024 08:40 Inactive
@vercel vercel bot temporarily deployed to Preview – guild-xyz-storybook July 17, 2024 08:47 Inactive
@vercel vercel bot temporarily deployed to Preview – guild-xyz-storybook July 17, 2024 08:53 Inactive
@vercel vercel bot temporarily deployed to Preview – guild-xyz-storybook July 17, 2024 09:01 Inactive
@vercel vercel bot temporarily deployed to Preview – guild-xyz-storybook July 17, 2024 10:33 Inactive
@dominik-stumpf dominik-stumpf marked this pull request as ready for review July 17, 2024 10:49
@vercel vercel bot temporarily deployed to Preview – guild-xyz-storybook July 17, 2024 10:50 Inactive
BrickheadJohnny
BrickheadJohnny approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@BrickheadJohnny BrickheadJohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 minor comments, but otherwise LGTM

@vercel vercel bot temporarily deployed to Preview – guild-xyz-storybook July 18, 2024 20:55 Inactive
@BrickheadJohnny BrickheadJohnny merged commit 335c81e into main Jul 20, 2024
7 checks passed
@BrickheadJohnny BrickheadJohnny deleted the circular-deps-fix-i2 branch July 20, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrickheadJohnny BrickheadJohnny BrickheadJohnny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominik-stumpf @BrickheadJohnny