Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): address type errors around rewards #1350

Conversation

dominik-stumpf
Copy link
Contributor

@dominik-stumpf dominik-stumpf commented Jul 3, 2024

Fixes type errors, circular imports

Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
guild-xyz ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 2:27pm

@dominik-stumpf dominik-stumpf marked this pull request as draft July 3, 2024 19:24
@dominik-stumpf dominik-stumpf changed the base branch from main to extract-components-from-rewards-config July 4, 2024 12:05
@BrickheadJohnny BrickheadJohnny marked this pull request as ready for review July 4, 2024 14:33
@BrickheadJohnny BrickheadJohnny merged commit b22980d into extract-components-from-rewards-config Jul 4, 2024
3 checks passed
@BrickheadJohnny BrickheadJohnny deleted the fix-rewards-type-errors branch July 4, 2024 14:34
BrickheadJohnny added a commit that referenced this pull request Jul 4, 2024
* refactor: create `components.ts` config for every reward type

* fix(type): address type errors around rewards (#1350)

* fix(type): address type errors around rewards

* fix: resolve type errors

* refactor: fix circular imports, add types

* refactor: add missed types

---------

Co-authored-by: Dominik Stumpf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants