resolve circular deps inside rewards

[dominik-stumpf]

Fixes 2 circular dependency group

• fix(SecretText): resolve circular dependency inside rewards
• fix(PolygonID): resolve circular dependency inside rewards

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
guild-xyz	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 3, 2024 5:39pm

[BrickheadJohnny]

I had 2 questions, let's discuss them 😉

[BrickheadJohnny]

I'm not sure if we need to put these types in a types.ts close to the components where we actually use them, or we should just put them in the main src/types.ts file. What are the pros and cons in your opinion?

[dominik-stumpf]

Pros:

• The src/types.ts won't grow unmaintainably (name collision, too large file, uncertain types)
• The types will be localized in some sense
• This way it's clear that the types.ts belongs to SecretText from every import, this gives the type additional data for the developers.

Cons:

• More files
• Global types don't require imports, as this one does so when something is renamed or moved, more refactor is required usually

I plan to write about these in the project structure convention, this is not something we do in the project now.