fix: remove Editor.UseThemeBackground (removed upstream in Editor#134)#136
Merged
Conversation
…134) Editor's syntax-theme phase 2 (gui-cs/Editor#134) removed UseThemeBackground from the Editor class — themes now control backgrounds directly via VisualRoles. Remove all Editor.UseThemeBackground references: - EditorClet: init property, optUseThemeBg toggle, View menu item - EditorSettings: property, managed key, save entry - EditorSettingsTests: assertions updated (8 → 7 keys) Markdown.UseThemeBackground (a TG View property) is unaffected. Fixes CI build failures on main. Closes #131 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Adopt Editor PR gui-cs/Editor#134 (syntax-theme phase 2): EditorClet: - Add Theme DropDownList to status bar (selects ThemeManager.Theme) - Markdown preview auto-selects TextMate theme based on terminal background instead of hard-coding DarkPlus ConfigClet: - Add Theme DropDownList to status bar - Add ViewportSettings (scrollbars) - Set BorderStyle = LineStyle.None for consistency with EditorClet The Editor class now auto-subscribes to ThemeManager.ThemeChanged internally, so changing the theme triggers proper repaint with VisualRole-driven syntax colors automatically. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tig
force-pushed
the
fix/remove-use-theme-background
branch
from
31d55e1 to
a2ddc7c
Compare
The wildcard 2.1.1-develop.* was resolving to .163 which is a bad build without the VisualRole.Code* tokens that Editor PR #134 relies on. Pin to .98 to match Editor's Directory.Build.props. Also remove obsolete GetThemeForBackground calls (now errors with TreatWarningsAsErrors) — syntax colors are resolved via VisualRoles. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Editor's syntax-theme phase 2 (gui-cs/Editor#134) removed \UseThemeBackground\ from the \Editor\ class — themes now control backgrounds directly via \VisualRole\ machinery. This broke both CI workflows on main:
Changes
Removes all \Editor.UseThemeBackground\ references:
\Markdown.UseThemeBackground\ (a TG \View\ property, not from Editor) is unaffected and remains in \MarkdownClet\ and \MarkdownHelpRenderer.
Doc-update gate
Closes #131