Editor: overwrite / insert-replace mode (Insert key)#156
Merged
Conversation
6 tasks
Add OverwriteMode property with field-keyword pattern, wire Command.ToggleOverwrite/EnableOverwrite/DisableOverwrite via AddCommand and DefaultKeyBindings (Insert key = default toggle). When overwrite is active and no selection exists and caret is not at line-end, typing replaces the grapheme under the caret (wide-rune safe via StringInfo.GetNextTextElementLength). Selection + line-end still insert. Each overwrite is a single undo step. Caret renders as SteadyBlock while overwrite is active. Multi-caret insert path also respects overwrite mode. ted: INS/OVR status bar indicator. specs: overwrite-mode/spec.md created; public-api.md updated. Tests: 11 new integration tests, all green. Agent-Logs-Url: https://github.com/gui-cs/Editor/sessions/e0fe7ce8-4870-47c6-87cf-9bd7b524f8e3 Co-authored-by: tig <585482+tig@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add overwrite mode functionality to Editor
Editor: overwrite / insert-replace mode (Insert key)
May 17, 2026
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da7da57c8b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editoris insert-only — no overwrite state, command, or caret style.TextViewsupports it; it's a widely-expected editor mode and not replicable by a consumer.Core
OverwriteModeproperty (field-keyword pattern, default off) +OverwriteModeChangedevent onEditorCommand.ToggleOverwrite/EnableOverwrite/DisableOverwritewired viaAddCommand; Insert key bound inDefaultKeyBindings(user-overridable[ConfigurationProperty])OverwriteAtOffset()helper: replaces the grapheme cluster at caret usingRemoveAndInsertoffset mapping so the caret anchor advances correctly. Wide-rune safe viaStringInfo.GetNextTextElementLength. Falls back to insert at line-end (never consumes newline). Selection still replaces normally.CursorStyle.SteadyBlockwhile overwrite is activeted
OverwriteModeChangedSpecs
specs/overwrite-mode/spec.mdcreatedspecs/public-api.mdupdated with new property and eventTests