Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prestapyt: [add] log debug #1

Open
wants to merge 1 commit into
base: use-requests
Choose a base branch
from
Open

Prestapyt: [add] log debug #1

wants to merge 1 commit into from

Conversation

gaelTorrecillas
Copy link

Hi @guewen,
this pull request concerns the addition of debug.

@guewen
Copy link
Owner

guewen commented Sep 20, 2016

I don't like very much when libraries change the configuration of logging. IMO the libraries should only log and let the users of the library actually setup the loggers.

@gaelTorrecillas gaelTorrecillas mentioned this pull request Sep 20, 2016
Closed
@gaelTorrecillas
Copy link
Author

gaelTorrecillas commented Sep 20, 2016 •
edited
Loading

@guewen I'm agree, this solution only enables or not the predefined debug.
In my connector_prestashop, the user has a box to active this debug.
I have used this solution for, among other things, perform the tests for PrestaShop
I could not propose the "debug mode" of PrestaShop if I could not use it

@guewen
Copy link
Owner

guewen commented Sep 21, 2016

This code could be in the prestashop connector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaelTorrecillas @guewen