iOS - Fix VoiceOver on SubNavigationView buttons #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a VoiceOver accessibility issue in SubNavigationView buttons where double-tap gestures were not being recognized. The fix moves the button selection logic from a simultaneousGesture modifier to the Button's action closure, ensuring proper VoiceOver functionality.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VoiceOver doesn't work properly on the SubNavigationView buttons in My Guardian (i.e. Following, Saved and History). Currently, when you tap on a button to highlight it and then double tap to select it, it doesn't react to the double tap and you stay on the My Guardian page you're currently on rather than switching to the one you tapped on. This is because we use a custom element with all the interaction logic in a
.simultaneousGesturerather than in the Button's action closure.Testing notes/instructions:
I tested this on a branch in the ios-live repo by replacing the remote Source package with a local one that included my changes, and verifying that VoiceOver now works as expected.
Checklist
Screenshots or videos:
Before
ScreenRecording_01-09-2026.11-08-55_1.MP4
After
ScreenRecording_01-09-2026.11-08-21_1.MP4