Repository navigation
Bump @guardian/consent-manager to 2.3.2 - #17274
Merged
Merged
Conversation
🚀 Image for dotcom-rendering pushed to AWS ECRImage digest: 🐛 Run the image locallyThe following can be used to run the image locally: # Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:a63c07a7409b7870bc18c086a134ca7a343e4bf0b0490c5b17ec14d10ab8b12f"
# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-al-bump-consent-manager-2-3-2"
# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-34591"
# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"
IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering/dotcom-rendering${IMAGE_IDENTIFIER}"
# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY
# Pull the image
docker pull $IMAGE
# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGEFrom guardian/actions-ecr. |
akinsola-guardian
marked this pull request as ready for review
November 17, 2026 14:04
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
pvighi
approved these changes
Nov 17, 2026
pvighi
left a comment
Contributor
There was a problem hiding this comment.
looks good to me, but the screenshots in the description are broken at least for me
|
Seen on PROD (merged by @akinsola-guardian 37 minutes and 14 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This updates the consent-manager to the latest version and the copy of the Privacy settings link footer
Why?
The consent-manager update (guardian/csnx#2575) includes an update to the targetingParams sent to Sourcepoint. We'll be adding an additional
excludePageto the usnat setupHow has this change been tested?
Deployed to CODE and checked the payload sent to Sourcepoint
[before]: https://example.com/before.png
[after]: https://example.com/after.png